Enable doc build workflow and build script for PR and Nightly#203
Enable doc build workflow and build script for PR and Nightly#203rapids-bot[bot] merged 19 commits intoNVIDIA:branch-25.08from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rgsl888prabhu
added
doc
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Left some suggestions for your consideration. There are enough that I'm leaving a blocking review.
|
@jameslamb may I get another set of reviews on this ? |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
I left some comments for your consideration. I think this can be simplified.
|
removed my blocking review, for the reasons mentioned in #199 (comment) Can help when I'm back if no one gets to it sooner, sorry. |
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Looks good overall, @rgsl888prabhu !
Can you make this addition to the update-version-rapids.sh script? That will handle auto-updating the calver-tagged docker images:
diff --git a/ci/release/update-version-rapids.sh b/ci/release/update-version-rapids.sh
index 6835e25..72f3e7c 100755
--- a/ci/release/update-version-rapids.sh
+++ b/ci/release/update-version-rapids.sh
@@ -53,6 +53,8 @@ done
# WORKFLOWS
for FILE in .github/workflows/*.yaml; do
sed_runner "/shared-workflows/ s/@.*/@branch-${NEXT_SHORT_TAG}/g" "${FILE}"
+ # CI image tags of the form {rapids_version}-{something}
+ sed_runner "s/:[0-9]*\\.[0-9]*-/:${NEXT_SHORT_TAG}-/g" "${FILE}"
done
# CI
|
@gforsyth Added the changes |
|
/merge |
…#203) Enabling doc build for PR and NIghtly workflow, this was disabled earlier since the documentation couldn't be built in github. But with OSS, documentation has changed. ## Issue closes NVIDIA#63 Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Gil Forsyth (https://github.com/gforsyth) URL: NVIDIA#203
3 participants
Description
Enabling doc build for PR and NIghtly workflow, this was disabled earlier since the documentation couldn't be built in github. But with OSS, documentation has changed.
Issue
closes #63
Checklist