PDLP solution file generation and binary fix#21
PDLP solution file generation and binary fix#21rapids-bot[bot] merged 12 commits intoNVIDIA:branch-25.05from
Conversation
Kh4ster
added
bug
| double solve_time; | ||
|
|
||
| /** Whether the problem was solved by PDLP or Dual Simplex */ | ||
| bool solved_by_pdlp; |
There was a problem hiding this comment.
Minor tangential remark but should the members of additional_termination_information_t possess default initializers? This is essentially a plain struct and I see that its instanciation sites initialize members manually, this might lead in the future to missed initializations/garbage output in write_additional_termination_statistics_to_file (e.g. if in some future codepath we forget to set solved_by_pdlp)
There was a problem hiding this comment.
Yes I think I agree. Should we initialized it with a "zero" value or "nan" value so that if those value appear we know we forgot something?
There was a problem hiding this comment.
My vote would be for NaN :) 0 may be valid in some context / mislead whoever is reading the solution log into thinking this is expected output
| @@ -128,6 +128,8 @@ class Solution: | |||
| Time used for pre-solve | |||
| solve_time: Float64 | |||
| Solve time in milliseconds | |||
There was a problem hiding this comment.
does this need to be seconds now?
|
/ok to test |
@Iroy30, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test 8953319 |
|
/merge |
This PR fixes two issues: 1. Solution file generated by PDLP presented several JSON issues, was still mentioning ms for the solve time and was not handling the potential missing fields from Dual Simplex. To handle the last and so that user can know, a bool was added to know which solver solved the LP problem 2. The default value for binary time limit was an int resulting in a bad any cast in case it was not set Authors: - Nicolas Blin (https://github.com/Kh4ster) - https://github.com/Iroy30 Approvers: - Alice Boucher (https://github.com/aliceb-nv) - https://github.com/Iroy30 URL: NVIDIA#21
5 participants
This PR fixes two issues: