Adding few more pre-commit checks to ensure coding standards#213
Merged
rapids-bot[bot] merged 13 commits intoNVIDIA:branch-25.08from Jul 17, 2025
Merged
Conversation
rgsl888prabhu
requested review from
Iroy30,
akifcorduk,
hlinsen,
jameslamb and
msarahan
and removed request for
msarahan
rgsl888prabhu
added
doc
jameslamb
approved these changes
Jul 16, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
This is great, thanks for doing it! I think you'll be glad you have this, and it should reduce the amount of annoying PR review comments about newlines, trailing space, etc. 😁
Left some very small suggestions, but approving... I don't need to review again.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Collaborator
Author
Thank you @jameslamb |
aliceb-nv
approved these changes
Jul 17, 2025
Collaborator
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
) The PR adds - end-of-file-fixer - expects a new line at the end of the file - trailing-whitespace - removes trailing white spaces - check-builtin-literals - check-executables-have-shebangs - check-json - check-yaml Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - James Lamb (https://github.com/jameslamb) - Alice Boucher (https://github.com/aliceb-nv) - Ishika Roy (https://github.com/Iroy30) URL: NVIDIA#213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR adds
Checklist