Handle out of memory and out of time limit issues gracefully#22
Merged
rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.05from May 21, 2025
Merged
Handle out of memory and out of time limit issues gracefully#22rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.05from
rapids-bot[bot] merged 2 commits intoNVIDIA:branch-25.05from
Conversation
…ception in C++ layer
Contributor
Author
|
/ok to test ab8d9d7 |
hlinsen
reviewed
May 20, 2025
chris-maes
reviewed
May 20, 2025
cpp/src/linear_programming/solve.cu
Outdated
Contributor
There was a problem hiding this comment.
Should a bad_alloc be a cuopt::logic_error? We might want to create a different cuopt exception for this.
Contributor
Author
There was a problem hiding this comment.
bad_alloc is thrown by rmm, unless we catch them somewhere and convert them to logic_error, which is what I am doing here
Contributor
Author
|
/ok to test 98411dd |
hlinsen
approved these changes
May 21, 2025
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
This PR adds two things: 1. Introduces a time limit for computing related variables. This function can take a lot of time for very large problems (in this case 20+ M variables). Ideally, we need to speed up this with a better algo and fine tune for larger problems 2. Catch `std::bad_alloc` exceptions in solve function. Currently, we only catch `cuopt::logic_error` Authors: - Rajesh Gandham (https://github.com/rg20) Approvers: - Hugo Linsenmaier (https://github.com/hlinsen) URL: NVIDIA#22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two things:
std::bad_allocexceptions in solve function. Currently, we only catchcuopt::logic_error