Remove cuda 11 specific changes from repo by rgsl888prabhu · Pull Request #222 · NVIDIA/cuopt

rgsl888prabhu · 2025-07-22T15:07:53Z

Description

This PR removes CUDA 11 pertaining changes since we have moved to CUDA 12 support only

Issue

closes #220

Checklist

I am familiar with the Contributing Guidelines.
Testing
- New or existing tests cover these changes
- Added tests
- Created an issue to follow-up
- NA
Documentation
- The documentation is up to date with these changes
- Added new documentation
- NA

Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>

…8prabhu/cuopt_public into remove_cuda_11_missing_references

jakirkham

Thanks Ram! 🙏

Had a couple comments below

jakirkham · 2025-07-22T16:12:38Z

    secrets: inherit
    uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-25.08
    with:
-      matrix_filter: map(select((.CUDA_VER | startswith("12"))))


Recognize we are only testing CUDA 12, but could we keep this?

Since we might move to cuda 13 in 25.10 or later, I removed it just for future case.

jakirkham · 2025-07-22T16:22:12Z

Could we please also take a look at this code?

cuopt/cpp/src/linear_programming/utilities/ping_pong_graph.cuh

Lines 48 to 63 in 9952c26

    
           void end_capture(i_t total_pdlp_iterations) 
        
           { 
        
             if (total_pdlp_iterations % 2 == 0 && !even_initialized) { 
        
               RAFT_CUDA_TRY(cudaStreamEndCapture(stream_view_.value(), &even_graph)); 
        
               // Extra NULL NULL 0 mandatory for cuda 11.8 
        
               RAFT_CUDA_TRY(cudaGraphInstantiate(&even_instance, even_graph, nullptr, nullptr, 0)); 
        
               even_initialized = true; 
        
               RAFT_CUDA_TRY_NO_THROW(cudaGraphDestroy(even_graph)); 
        
             } else if (total_pdlp_iterations % 2 == 1 && !odd_initialized) { 
        
               RAFT_CUDA_TRY(cudaStreamEndCapture(stream_view_.value(), &odd_graph)); 
        
               // Extra NULL NULL 0 mandatory for cuda 11.8 
        
               RAFT_CUDA_TRY(cudaGraphInstantiate(&odd_instance, odd_graph, nullptr, nullptr, 0)); 
        
               odd_initialized = true; 
        
               RAFT_CUDA_TRY_NO_THROW(cudaGraphDestroy(odd_graph)); 
        
             } 
        
           }

Edit: Also this CMake code

cuopt/cpp/CMakeLists.txt

Lines 222 to 224 in 47fb158

    
           if(CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA" AND CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.4) 
        
             list(PREPEND CUOPT_PRIVATE_CUDA_LIBS CUDA::cublasLt) 
        
           endif()

rgsl888prabhu · 2025-07-22T16:23:49Z

Could we please also take a look at this code?

cuopt/cpp/src/linear_programming/utilities/ping_pong_graph.cuh

Lines 48 to 63 in 9952c26

void end_capture(i_t total_pdlp_iterations)

{

if (total_pdlp_iterations % 2 == 0 && !even_initialized) {

RAFT_CUDA_TRY(cudaStreamEndCapture(stream_view_.value(), &even_graph));

// Extra NULL NULL 0 mandatory for cuda 11.8

RAFT_CUDA_TRY(cudaGraphInstantiate(&even_instance, even_graph, nullptr, nullptr, 0));

even_initialized = true;

RAFT_CUDA_TRY_NO_THROW(cudaGraphDestroy(even_graph));

} else if (total_pdlp_iterations % 2 == 1 && !odd_initialized) {

RAFT_CUDA_TRY(cudaStreamEndCapture(stream_view_.value(), &odd_graph));

// Extra NULL NULL 0 mandatory for cuda 11.8

RAFT_CUDA_TRY(cudaGraphInstantiate(&odd_instance, odd_graph, nullptr, nullptr, 0));

odd_initialized = true;

RAFT_CUDA_TRY_NO_THROW(cudaGraphDestroy(odd_graph));

}

}

Yes, I am currently discussing with team on how much effort would it have and asked them to push changes to this PR. Meanwhile, I will keep don't merge tag to this.

jakirkham · 2025-07-22T20:17:29Z

Thanks Ram! 🙏

Can you please look at this CMake code as well?

cuopt/cpp/CMakeLists.txt

Lines 222 to 224 in 47fb158

    
           if(CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA" AND CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.4) 
        
             list(PREPEND CUOPT_PRIVATE_CUDA_LIBS CUDA::cublasLt) 
        
           endif()

rgsl888prabhu · 2025-07-22T20:21:24Z

Thanks Ram! 🙏

Can you please look at this CMake code as well?

cuopt/cpp/CMakeLists.txt

Lines 222 to 224 in 47fb158

if(CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA" AND CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.4)

list(PREPEND CUOPT_PRIVATE_CUDA_LIBS CUDA::cublasLt)

endif()

Removed if conditions around it.

rgsl888prabhu · 2025-07-23T19:27:25Z

@jakirkham May I get another set of review and also had few questions on previous reviews

akifcorduk

Looks good on cpp side.

bdice

One small suggestion to clarify a comment, otherwise LGTM. We should land this soon for 25.08.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

rgsl888prabhu · 2025-07-28T22:17:13Z

/merge

jakirkham · 2025-07-28T23:59:57Z

Thanks Ram and thanks to all the reviewers! 🙏

Agree this looks good

This PR removes CUDA 11 pertaining changes since we have moved to CUDA 12 support only ## Issue closes NVIDIA#220 Authors: - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Trevor McKay (https://github.com/tmckayus) - Ishika Roy (https://github.com/Iroy30) - Nicolas Blin (https://github.com/Kh4ster) - Akif ÇÖRDÜK (https://github.com/akifcorduk) - Bradley Dice (https://github.com/bdice) URL: NVIDIA#222

remove cuda 11 specific changes

1f9f356

rgsl888prabhu requested review from a team as code owners July 22, 2025 15:07

rgsl888prabhu requested review from Iroy30 and vyasr July 22, 2025 15:07

rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jul 22, 2025

rgsl888prabhu self-assigned this Jul 22, 2025

KyleFromNVIDIA requested changes Jul 22, 2025

View reviewed changes

Comment thread .github/workflows/build.yaml

Comment thread build.sh Outdated

Comment thread .github/workflows/pr.yaml Outdated

rgsl888prabhu and others added 3 commits July 22, 2025 10:16

Update build.sh

5f9679c

Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>

update

7ff237d

Merge branch 'remove_cuda_11_missing_references' of github.com:rgsl88…

e5c3183

…8prabhu/cuopt_public into remove_cuda_11_missing_references

KyleFromNVIDIA approved these changes Jul 22, 2025

View reviewed changes

tmckayus approved these changes Jul 22, 2025

View reviewed changes

Iroy30 approved these changes Jul 22, 2025

View reviewed changes

jakirkham reviewed Jul 22, 2025

View reviewed changes

rgsl888prabhu added the do not merge Do not merge if this flag is set label Jul 22, 2025

remove additional nullptr and 0 usage required for 11.8

5f90652

rgsl888prabhu requested a review from a team as a code owner July 22, 2025 19:34

rgsl888prabhu requested review from Kh4ster and akifcorduk July 22, 2025 19:34

rgsl888prabhu added non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change do not merge Do not merge if this flag is set labels Jul 22, 2025

address review comments

b556bea

Merge branch 'branch-25.08' into remove_cuda_11_missing_references

aed3d6f

hlinsen reviewed Jul 24, 2025

View reviewed changes

Comment thread cpp/src/linear_programming/utilities/ping_pong_graph.cuh Outdated

address review comments

84d67fd

rgsl888prabhu requested review from hlinsen and jakirkham July 24, 2025 19:03

Kh4ster approved these changes Jul 25, 2025

View reviewed changes

akifcorduk approved these changes Jul 25, 2025

View reviewed changes

Merge branch 'branch-25.08' into remove_cuda_11_missing_references

9957d48

bdice approved these changes Jul 26, 2025

View reviewed changes

Comment thread .github/workflows/build.yaml

Comment thread build.sh Outdated

rgsl888prabhu and others added 2 commits July 28, 2025 11:05

Update build.sh

ce427fa

Co-authored-by: Bradley Dice <bdice@bradleydice.com>

Merge branch 'branch-25.08' into remove_cuda_11_missing_references

66cfd63

rapids-bot bot merged commit 7441095 into NVIDIA:branch-25.08 Jul 28, 2025
281 of 286 checks passed

Conversation

rgsl888prabhu commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakirkham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakirkham Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

rgsl888prabhu Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

jakirkham commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgsl888prabhu commented Jul 22, 2025

Uh oh!

jakirkham commented Jul 22, 2025

Uh oh!

rgsl888prabhu commented Jul 22, 2025

Uh oh!

rgsl888prabhu commented Jul 23, 2025

Uh oh!

Uh oh!

akifcorduk left a comment

Choose a reason for hiding this comment

Uh oh!

bdice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rgsl888prabhu commented Jul 28, 2025

Uh oh!

Uh oh!

jakirkham commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rgsl888prabhu commented Jul 22, 2025 •

edited

Loading

jakirkham commented Jul 22, 2025 •

edited

Loading