Skip to content

Fix bug on initial solution size in the check and cuda set device order#226

Merged
rapids-bot[bot] merged 5 commits intoNVIDIA:branch-25.08from
akifcorduk:initial_sol_bug
Jul 25, 2025
Merged

Fix bug on initial solution size in the check and cuda set device order#226
rapids-bot[bot] merged 5 commits intoNVIDIA:branch-25.08from
akifcorduk:initial_sol_bug

Conversation

@akifcorduk
Copy link
Copy Markdown
Contributor

@akifcorduk akifcorduk commented Jul 23, 2025

This fixes a bug on the variable violation check where the check is done on a wrong size. This also fixes the bug in set_simplex_solution in which the lp_optimal_solution might not be allocated by the time simplex found a solution, and another bug of cuda_set_device was called after some GPU operations in assert mode.

closes #221

@akifcorduk akifcorduk added this to the 25.08 milestone Jul 23, 2025
@akifcorduk akifcorduk added the bug Something isn't working label Jul 23, 2025
@akifcorduk akifcorduk requested a review from a team as a code owner July 23, 2025 12:29
@akifcorduk akifcorduk added the non-breaking Introduces a non-breaking change label Jul 23, 2025
@akifcorduk akifcorduk requested review from chris-maes and rg20 July 23, 2025 12:29
Copy link
Copy Markdown
Contributor

@aliceb-nv aliceb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Akif!

@akifcorduk akifcorduk requested review from a team as code owners July 25, 2025 10:18
@akifcorduk akifcorduk requested review from AyodeAwe and Iroy30 July 25, 2025 10:18
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit ecc6a76 into NVIDIA:branch-25.08 Jul 25, 2025
73 checks passed
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
…er (NVIDIA#226)

This fixes a bug on the variable violation check where the check is done on a wrong size. This also fixes the bug in set_simplex_solution in which the lp_optimal_solution might not be allocated by the time simplex found a solution, and another bug of cuda_set_device was called after some GPU operations in assert mode.

closes NVIDIA#221

Authors:
  - Akif ÇÖRDÜK (https://github.com/akifcorduk)

Approvers:
  - Alice Boucher (https://github.com/aliceb-nv)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: NVIDIA#226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Initial user solutions incorrectly rejected after presolve

3 participants