Skip to content

Fix bug in crossover where numerical was returned instead of time limit#23

Merged
rapids-bot[bot] merged 1 commit intobranch-25.05from
fix_numerical_error_crossover
May 21, 2025
Merged

Fix bug in crossover where numerical was returned instead of time limit#23
rapids-bot[bot] merged 1 commit intobranch-25.05from
fix_numerical_error_crossover

Conversation

@chris-maes
Copy link
Copy Markdown
Contributor

Also adds the --relaxation flag to cuopt_cli to solve the LP relaxation of a MIP

Also adds the --relaxation flag to cuopt_cli to solve the LP relaxation
of a MIP
@chris-maes chris-maes requested a review from a team as a code owner May 20, 2025 23:02
@chris-maes chris-maes requested review from Kh4ster and rg20 May 20, 2025 23:02
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented May 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change labels May 20, 2025
@chris-maes chris-maes added this to the 25.05 milestone May 20, 2025
@chris-maes chris-maes self-assigned this May 20, 2025
@chris-maes
Copy link
Copy Markdown
Contributor Author

/ok to test 1876963

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented May 20, 2025

/ok to test 1876963

@chris-maes, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@chris-maes
Copy link
Copy Markdown
Contributor Author

/ok to test 1876936

Comment thread cpp/cuopt_cli.cpp
std::string file_name = program.get<std::string>("filename");

const auto initial_solution_file = program.get<std::string>("--initial-solution");
const auto solve_relaxation = program.get<bool>("--relaxation");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this handle true false words as well? or just 0 and 1 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like a flag. If you add --relaxation the value is true, if you don't add that option the value is false. I thought it should be different than the other parameter settings (since this is not a parameter).

Copy link
Copy Markdown
Contributor

@Kh4ster Kh4ster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@rg20
Copy link
Copy Markdown
Contributor

rg20 commented May 21, 2025

/merge

@rapids-bot rapids-bot bot merged commit ae9a068 into branch-25.05 May 21, 2025
84 checks passed
@rgsl888prabhu rgsl888prabhu deleted the fix_numerical_error_crossover branch October 29, 2025 16:26
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
…it (NVIDIA#23)

Also adds the --relaxation flag to cuopt_cli to solve the LP relaxation of a MIP

Authors:
  - Chris Maes (https://github.com/chris-maes)

Approvers:
  - Nicolas Blin (https://github.com/Kh4ster)

URL: NVIDIA#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants