Manual cuda graph creation in load balanced bounds presolve#242
Merged
rapids-bot[bot] merged 6 commits intoNVIDIA:branch-25.08from Jul 31, 2025
Merged
Manual cuda graph creation in load balanced bounds presolve#242rapids-bot[bot] merged 6 commits intoNVIDIA:branch-25.08from
rapids-bot[bot] merged 6 commits intoNVIDIA:branch-25.08from
Conversation
kaatish
added
bug
Contributor
|
This one is critical for 25.08 |
Contributor
|
/ok to test 8596529 |
Collaborator
|
/ok to test 10f87ea |
Collaborator
|
@kaatish Should we merge this PR ? |
Contributor
Author
|
/ok to test 2bb8de9 |
kaatish
changed the title
Contributor
Author
|
/ok to test 18b7202 |
Contributor
Author
|
/ok to test 5502c8d |
rgsl888prabhu
approved these changes
Jul 31, 2025
Collaborator
rgsl888prabhu
left a comment
rgsl888prabhu
left a comment
There was a problem hiding this comment.
minor suggestion, rest looks good
hlinsen
approved these changes
Jul 31, 2025
hlinsen
reviewed
Jul 31, 2025
| { | ||
| using f_t2 = typename type_2<f_t>::type; | ||
| cudaGraph_t cnst_slack_graph; | ||
| cudaGraphCreate(&cnst_slack_graph, 0); |
Contributor
There was a problem hiding this comment.
Are we recreating the graph each time?
Contributor
Author
There was a problem hiding this comment.
We create this structure to add graph nodes to it. Once the structure is complete, we instantiate the actual graph with a call like :
cudaGraphInstantiate(&upd_bnd_exec, upd_graph, NULL, NULL, 0);
This is done once per graph in the setup function inside constructor by calling either create_bounds_update_graph() or create_constraint_slack_graph().
Contributor
Author
|
/ok to test e6afa2e |
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
This PR removes cuda graph capture from load balanced bounds strengthening to address crashes encountered in the constructor. The cuda graph is instead created manually. Fixes NVIDIA#219 Authors: - Kumar Aatish (https://github.com/kaatish) Approvers: - Ramakrishnap (https://github.com/rgsl888prabhu) - Hugo Linsenmaier (https://github.com/hlinsen) URL: NVIDIA#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes cuda graph capture from load balanced bounds strengthening to address crashes encountered in the constructor. The cuda graph is instead created manually. Fixes #219