Bug fixes on preprocess, line segment returning worse solution, temporary fix add B&B solution directly#27
Merged
rapids-bot[bot] merged 12 commits intoNVIDIA:branch-25.05from May 22, 2025
Conversation
…nning kernels in other places too
…ion multiple times
… B&B solution not directly added
hlinsen
reviewed
May 22, 2025
cpp/src/mip/problem/problem.cu
Outdated
| temp_assignment.begin(), | ||
| assignment.begin()); | ||
| handle_ptr->sync_stream(); | ||
| auto has_nans = cuopt::linear_programming::detail::has_nans(handle_ptr, assignment); |
Contributor
There was a problem hiding this comment.
This will cause errors if not caught before
| } | ||
|
|
||
| auto has_variable_bounds_violation = | ||
| cuopt::linear_programming::detail::has_variable_bounds_violation(handle_ptr, assignment, this); |
Contributor
There was a problem hiding this comment.
Does it solve the issue if you pass original problem bounds here?
Contributor
Author
There was a problem hiding this comment.
Probably, i didn't try it. But it was not accepting the solutions we outputted with get_solution.
Contributor
There was a problem hiding this comment.
Because bounds are scaled so I think this is the issue
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
…rary fix add B&B solution directly (NVIDIA#27) This PR fixes bugs in - Preprocess in set callback function, the checks were done on the original assignment before preprocess, thus rejecting almost all set_solution calls. - Line segment returning worse solutions because of bug. - A side effect of LS returning worse solutions is that B&B added solutions are not added to the population as LS makes them worse. Authors: - Akif ÇÖRDÜK (https://github.com/akifcorduk) Approvers: - Alice Boucher (https://github.com/aliceb-nv) - Hugo Linsenmaier (https://github.com/hlinsen) URL: NVIDIA#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in