Skip to content

Fix graph bug seen when using batch#34

Merged
rapids-bot[bot] merged 9 commits intoNVIDIA:branch-25.05from
Kh4ster:pdlp_fix_graph_batch
May 23, 2025
Merged

Fix graph bug seen when using batch#34
rapids-bot[bot] merged 9 commits intoNVIDIA:branch-25.05from
Kh4ster:pdlp_fix_graph_batch

Conversation

@Kh4ster
Copy link
Copy Markdown
Contributor

@Kh4ster Kh4ster commented May 23, 2025

Should fix the interment CI issue we were seeing in batch mode

It was possible for another CPU thread to call cudaMemcpyToSymbol while another was trying to capture on its stream. Solved by switching to the async API and use stream so that the call doesn't end up on the default stream.

@Kh4ster Kh4ster requested a review from a team as a code owner May 23, 2025 12:39
@Kh4ster Kh4ster requested review from chris-maes and rg20 May 23, 2025 12:39
@Kh4ster Kh4ster added bug Something isn't working non-breaking Introduces a non-breaking change pdlp labels May 23, 2025
@Kh4ster
Copy link
Copy Markdown
Contributor Author

Kh4ster commented May 23, 2025

/ok to test

@Kh4ster Kh4ster removed request for chris-maes and rg20 May 23, 2025 12:56
@akifcorduk akifcorduk added pdlp and removed pdlp labels May 23, 2025
@akifcorduk akifcorduk added this to the 25.05 milestone May 23, 2025
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/ok to test 24d796f

@Kh4ster Kh4ster requested review from a team as code owners May 23, 2025 13:27
@Kh4ster Kh4ster requested review from Iroy30 and rgsl888prabhu and removed request for Iroy30 May 23, 2025 13:27
@Kh4ster
Copy link
Copy Markdown
Contributor Author

Kh4ster commented May 23, 2025

/merge

@rapids-bot rapids-bot bot merged commit 82de1e4 into NVIDIA:branch-25.05 May 23, 2025
56 checks passed
@Kh4ster Kh4ster deleted the pdlp_fix_graph_batch branch May 23, 2025 14:31
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
Should fix the interment CI issue we were seeing in batch mode

It was possible for another CPU thread to call cudaMemcpyToSymbol while another was trying to capture on its stream. Solved by switching to the async API and use stream so that the call doesn't end up on the default stream.

Authors:
  - Nicolas Blin (https://github.com/Kh4ster)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Akif ÇÖRDÜK (https://github.com/akifcorduk)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: NVIDIA#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change pdlp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants