Skip to content

Address cuOpt doc reviews #41

Merged
rapids-bot[bot] merged 14 commits intoNVIDIA:branch-25.05from
rgsl888prabhu:address_doc_reviews_1
May 29, 2025
Merged

Address cuOpt doc reviews #41
rapids-bot[bot] merged 14 commits intoNVIDIA:branch-25.05from
rgsl888prabhu:address_doc_reviews_1

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Address VDR and VPR review comments

@rgsl888prabhu rgsl888prabhu changed the title Address cuOpt reviews Address cuOpt doc reviews May 27, 2025
@rgsl888prabhu rgsl888prabhu added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change improvement Improves an existing functionality and removed improvement Improves an existing functionality labels May 27, 2025
Copy link
Copy Markdown
Contributor

@cwilkinson76 cwilkinson76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes here look good to me

@rgsl888prabhu rgsl888prabhu requested review from a team as code owners May 27, 2025 23:04
Copy link
Copy Markdown
Contributor

@chris-maes chris-maes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@tmckayus tmckayus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple of typos I noticed

Copy link
Copy Markdown
Contributor

@cwilkinson76 cwilkinson76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments where changes are needed

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit f4cd784 into NVIDIA:branch-25.05 May 29, 2025
57 checks passed
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
Address VDR and VPR review comments

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Cindy Wilkinson (https://github.com/cwilkinson76)
  - Chris Maes (https://github.com/chris-maes)
  - Rajesh Gandham (https://github.com/rg20)
  - Trevor McKay (https://github.com/tmckayus)

URL: NVIDIA#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants