Fix return on size mismatch in Barrier#489
Merged
rapids-bot[bot] merged 1 commit intoNVIDIA:branch-25.10from Oct 14, 2025
Merged
Fix return on size mismatch in Barrier#489rapids-bot[bot] merged 1 commit intoNVIDIA:branch-25.10from
rapids-bot[bot] merged 1 commit intoNVIDIA:branch-25.10from
Conversation
rgsl888prabhu
added
non-breaking
chris-maes
reviewed
Oct 13, 2025
| @@ -568,7 +568,7 @@ class sparse_cholesky_cudss_t : public sparse_cholesky_base_t<i_t, f_t> { | |||
| #endif | |||
| if (A_in.n != n) { | |||
| printf("Analyze input does not match size %d != %d\n", A_in.n, n); | |||
Contributor
There was a problem hiding this comment.
Maybe we should do settings.log.printf("Analyze ..") here? So it goes to the log.
chris-maes
approved these changes
Oct 13, 2025
Contributor
chris-maes
left a comment
chris-maes
left a comment
There was a problem hiding this comment.
LGTM. Thanks Hugo. Let me know if you are able to track down the reason for the mismatch.
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Check reason of mismtach