Fix obj constant on max. Fix undefined memory access at root#52
Merged
rgsl888prabhu merged 5 commits intoNVIDIA:branch-25.05from Jun 3, 2025
Merged
Fix obj constant on max. Fix undefined memory access at root#52rgsl888prabhu merged 5 commits intoNVIDIA:branch-25.05from
rgsl888prabhu merged 5 commits intoNVIDIA:branch-25.05from
Conversation
…hen solved at root node
Contributor
Author
|
/ok to test |
@chris-maes, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
akifcorduk
approved these changes
May 31, 2025
tmckayus
approved these changes
Jun 2, 2025
Collaborator
|
/ok to test 7565dd7 |
Contributor
Author
|
/ok to test c6d9f6d |
Contributor
Author
|
/ok to test b0e612e |
Contributor
Author
|
/merge |
1 similar comment
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
This PR fixes two bugs discovered while testing the AMPL interface: 1) We weren't correctly calculating the objective constant when presolve eliminated variables on a maximization problem. Thanks to Alice for the quick fix! 2) We had an undefined memory access on the number of nodes and simplex iterations when solving a MIP at the root node. --------- Co-authored-by: Ramakrishnap <42624703+rgsl888prabhu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs discovered while testing the AMPL interface:
Thanks to Alice for the quick fix!