Fix data initialization in create depot node for max travel time feature#74
Merged
rapids-bot[bot] merged 4 commits intoNVIDIA:branch-25.08from Jul 24, 2025
Merged
Conversation
hlinsen
requested review from
rg20
and removed request for
a team,
Kh4ster and
rgsl888prabhu
hlinsen
requested review from
KyleFromNVIDIA
and removed request for
KyleFromNVIDIA
jameslamb
approved these changes
Jun 9, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Giving you a cuopt-ci-codeowners approval. The CMake changes look ok to me.
Collaborator
|
@rg20 @akifcorduk May I get your review on this PR #42 |
akifcorduk
approved these changes
Jul 23, 2025
Contributor
akifcorduk
left a comment
akifcorduk
left a comment
There was a problem hiding this comment.
Looks good. One question, why are we removing cycle finder tests?
Contributor
Author
These tests were added in the beginning of CF development and with API changes it is broken now as it is not run in CI. The cost checks are also done in assert mode already. Do you think there is value in keeping it? |
Contributor
Author
|
/merge |
aliceb-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
…ure (#74) This PR fixes: - Fixes data init in create depot node when wait time is modeled. This is used for move eval in 2-opt and OX. - Fixes an assertion when computed arrival time is checked and wait time is modeled - Removes deprecated tests Authors: - Hugo Linsenmaier (https://github.com/hlinsen) - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - James Lamb (https://github.com/jameslamb) - Akif ÇÖRDÜK (https://github.com/akifcorduk) URL: #74
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
…ure (NVIDIA#74) This PR fixes: - Fixes data init in create depot node when wait time is modeled. This is used for move eval in 2-opt and OX. - Fixes an assertion when computed arrival time is checked and wait time is modeled - Removes deprecated tests Authors: - Hugo Linsenmaier (https://github.com/hlinsen) - Ramakrishnap (https://github.com/rgsl888prabhu) Approvers: - James Lamb (https://github.com/jameslamb) - Akif ÇÖRDÜK (https://github.com/akifcorduk) URL: NVIDIA#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: