Skip to content

Migrate to modern logger interface#80

Merged
rgsl888prabhu merged 1 commit intoNVIDIA:branch-25.05from
emmanuel-ferdman:branch-25.05
Jun 9, 2025
Merged

Migrate to modern logger interface#80
rgsl888prabhu merged 1 commit intoNVIDIA:branch-25.05from
emmanuel-ferdman:branch-25.05

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

Description

The logger.warn() method is deprecated since Python2.7 and replaced with logger.warning(). It leads to those warnings:

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead

This small PR resolves those warnings. It also fixes a few typos along the way.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner June 7, 2025 10:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 9, 2025
@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/ok to test

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jun 9, 2025

/ok to test

@rgsl888prabhu, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/ok to test 7b4403f

Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @emmanuel-ferdman, appreciate your contribution to cuOpt. Please feel free to make PRs to improve cuOpt and suggest any features that would enhance cuOpt to serve the community better.

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

/merge

@rgsl888prabhu rgsl888prabhu merged commit ab1cc5c into NVIDIA:branch-25.05 Jun 9, 2025
58 checks passed
Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
## Description
The `logger.warn()` method is deprecated since Python2.7 and replaced
with `logger.warning()`. It leads to those warnings:
```python
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```
This small PR resolves those warnings. It also fixes a few typos along
the way.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants