Skip to content

move ruff configuration into pyproject.toml #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jan 29, 2026
Merged

move ruff configuration into pyproject.toml #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b99f9c
move ruff configuration into pyproject.toml
jameslamb Jan 27, 2026
0399886
Update versions1.json
rgsl888prabhu Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .flake8
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ docs/ @nvidia/cuopt-infra-codeowners
container-builder/ @nvidia/cuopt-infra-codeowners

#CI code owners
.flake8 @nvidia/cuopt-ci-codeowners
/.github/ @nvidia/cuopt-ci-codeowners
/ci/ @nvidia/cuopt-ci-codeowners
/.pre-commit-config.yaml @nvidia/cuopt-ci-codeowners
Expand Down
5 changes: 2 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2019-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

repos:
Expand All @@ -19,7 +19,7 @@ repos:
rev: v0.14.3
hooks:
- id: ruff-check
args: [--fix]
args: [--fix, --config, pyproject.toml]
- id: ruff-format
- repo: https://github.com/PyCQA/pydocstyle
rev: 6.1.1
Expand Down Expand Up @@ -68,7 +68,6 @@ repos:
^[.]pre-commit-config[.]yaml$|
Dockerfile$|
dependencies[.]yaml$|
^[.]flake8$|
Makefile$|
setup[.]cfg$|
pyproject[.]toml$
Expand Down
12 changes: 6 additions & 6 deletions ci/utils/nbtestlog2junitxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2019-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

import re
Expand All @@ -7,13 +7,13 @@
from os import path
from xml.etree.ElementTree import Element, ElementTree

startingPatt = re.compile("^STARTING: ([\w\.\-]+)$")
startingPatt = re.compile(r"^STARTING: ([\w\.\-]+)$")
skippingPatt = re.compile(
"^SKIPPING: ([\w\.\-]+)\s*(\(([\w\.\-\ \,]+)\))?\s*$"
r"^SKIPPING: ([\w\.\-]+)\s*(\(([\w\.\-\ \,]+)\))?\s*$"
)
exitCodePatt = re.compile("^EXIT CODE: (\d+)$")
folderPatt = re.compile("^FOLDER: ([\w\.\-]+)$")
timePatt = re.compile("^real\s+([\d\.ms]+)$")
exitCodePatt = re.compile(r"^EXIT CODE: (\d+)$")
folderPatt = re.compile(r"^FOLDER: ([\w\.\-]+)$")
timePatt = re.compile(r"^real\s+([\d\.ms]+)$")
linePatt = re.compile("^" + ("-" * 80) + "$")


Expand Down
8 changes: 6 additions & 2 deletions docs/cuopt/source/versions1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
[
{
"version": "26.02.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/26.02.00/",
"version": "26.04.00",
Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made by just running pre-commit run --all-files. I'm not sure what's causing it.

Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was manually added and needs update to the update script handle it with url now.

Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in this PR https://github.com/NVIDIA/cuopt/pull/810/files

Copy link
Copy Markdown
Member Author

@jameslamb jameslamb Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok got it, thanks

"url": "https://docs.nvidia.com/cuopt/user-guide/26.04.00/",
"name": "latest",
"preferred": true
},
{
"version": "26.02.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/26.02.00/"
},
Comment on lines +3 to +11
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

https://docs.nvidia.com/cuopt/user-guide/26.04.00/

💡 Result:

The URL you provided (https://docs.nvidia.com/cuopt/user-guide/26.04.00/) currently returns 404 Not Found, which suggests that a “26.04.00” cuOpt User Guide isn’t published at that path (or the versioned URL format differs). [1]

What is available is the cuOpt documentation hub and the User Guide under the “latest” path, which currently shows NVIDIA cuOpt (25.12) and includes a “Choose version” selector. [2][3]

Use these instead:

  • Documentation hub: https://docs.nvidia.com/cuopt/index.html [2]
  • User Guide (latest): https://docs.nvidia.com/cuopt/user-guide/latest/introduction.html [3]

If you tell me what you’re trying to find in 26.04.00 (release notes, installation, API reference, etc.), I can help locate the closest matching version/page.

Sources:
[1] NVIDIA Docs – 404 for the provided 26.04.00 URL
[2] NVIDIA cuOpt documentation hub (docs.nvidia.com/cuopt)
[3] NVIDIA cuOpt User Guide “latest” (shows version 25.12 + version picker)

🌐 Web query:

https://docs.nvidia.com/cuopt/user-guide/26.02.00/

💡 Result:

The URL you provided (https://docs.nvidia.com/cuopt/user-guide/26.02.00/) currently returns 404 Not Found, so NVIDIA doesn’t appear to have published the 26.02.00 cuOpt User Guide at that path. [1]

What you can use instead:

  • cuOpt documentation hub (entry point to the published docs): [2]
  • Published cuOpt User Guide (example: 25.02): [3]
  • “latest” docs endpoint (example: OpenAPI/Swagger under latest/): [4]

Sources: [1] [2] [3] [4]

🌐 Web query:

https://docs.nvidia.com/cuopt/user-guide/latest/

💡 Result:

The link points to the NVIDIA cuOpt User Guide (version 25.12), which documents cuOpt’s capabilities and how to use it via multiple interfaces. [1]

  • What cuOpt is: A GPU-accelerated optimization library for MILP, LP, QP, and vehicle routing problems (VRP), aimed at large-scale problems and deployable across cloud/data center/workstations; APIs wrap a C++ core. [2]
  • What’s in the guide: Sections for features (Routing, LP/QP, MILP), C API docs + examples, Python API docs + examples (routing + LP/QP/MILP), server (service, CLI, OpenAPI/Swagger, clients, cloud guides), CLI, and third-party modeling languages (AMPL, GAMS/GAMSPy, PuLP, JuMP). [1]
  • Installation options covered: Source (GitHub), pip wheels, conda packages, and containers (Docker Hub nvidia/cuopt and NVIDIA NGC for AI Enterprise). [2]
  • System requirements (high level): Supports x86-64/ARM64, needs NVIDIA GPU Volta+ (CC ≥ 7.0), CUDA 12.0+, and lists specific CUDA↔driver minimums; for best performance it recommends H100 SXM, CUDA 13.0, and driver 580.65.06+. [3]
  • Release notes (25.12 highlights): Adds a barrier-method QP solver (beta), quadratic objectives in C & Python modeling APIs, multi-GPU concurrent LP mode, plus various MILP/LP improvements and fixes. [4]

Sources: NVIDIA cuOpt User Guide (latest): main index [1], introduction [2], system requirements [3], release notes [4].

Do not merge: 26.04.00 and 26.02.00 documentation links are not live (404).

The URLs for versions 26.04.00 and 26.02.00 currently return 404 errors. The /latest/ alias still serves version 25.12 docs. Merging this change will introduce broken links in the version picker. Either confirm that the docs for these versions are published and available at the specified URLs, or defer this change until they are deployed.

Rollback option 
-  {
-    "version": "26.04.00",
-    "url": "https://docs.nvidia.com/cuopt/user-guide/26.04.00/",
-    "name": "latest",
-    "preferred": true
-  },
-  {
-    "version": "26.02.00",
-    "url": "https://docs.nvidia.com/cuopt/user-guide/26.02.00/"
-  },
+  {
+    "version": "25.12.00",
+    "url": "https://docs.nvidia.com/cuopt/user-guide/25.12.00/",
+    "name": "latest",
+    "preferred": true
+  },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"version": "26.04.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/26.04.00/",
"name": "latest",
"preferred": true
},
{
"version": "26.02.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/26.02.00/"
},
"version": "25.12.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/25.12.00/",
"name": "latest",
"preferred": true
},
🤖 Prompt for AI Agents 
In `@docs/cuopt/source/versions1.json` around lines 3 - 11, The versions1.json
entries for "version": "26.04.00" and "version": "26.02.00" point to URLs that
return 404; before merging either confirm those docs are published and update
the "url" fields to the correct live endpoints (and set "preferred": true only
for the proper release) or remove/rollback the two version objects so the
version picker doesn't include broken links; locate the JSON objects by the
"version" keys and the "url"/"preferred"/"name" fields to make the change.

Copy link
Copy Markdown
Collaborator

@rgsl888prabhu rgsl888prabhu Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeabbitai this is future release

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

{
"version": "25.12.00",
"url": "https://docs.nvidia.com/cuopt/user-guide/25.12.00/"
Expand Down
16 changes: 15 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,23 @@ extend-exclude = [
"__init__.py",
]

[tool.ruff.lint]
select = [
# pycodestyle (errors)
"E",
# pyflakes
"F",
# pycodestyle (warnings)
"W"
]
ignore = [
# (pycodestyle) line too long
"E501"
]

[tool.ruff.lint.per-file-ignores]
"*.ipynb" = [
# unused imports
# (pyflakes) unused imports
"F401",
]

Expand Down