Skip to content

Fix test commands in CONTRIBUTING.md#88

Merged
rgsl888prabhu merged 1 commit intoNVIDIA:branch-25.05from
rgsl888prabhu:update_contri_for_dataset
Jun 10, 2025
Merged

Fix test commands in CONTRIBUTING.md#88
rgsl888prabhu merged 1 commit intoNVIDIA:branch-25.05from
rgsl888prabhu:update_contri_for_dataset

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Minor doc fix to ensure commands to fetch test datasets are instructed to be run the right working directory.

closes #86

@rgsl888prabhu rgsl888prabhu requested a review from aliceb-nv June 10, 2025 14:40
@rgsl888prabhu rgsl888prabhu self-assigned this Jun 10, 2025
@rgsl888prabhu rgsl888prabhu added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Jun 10, 2025
@rgsl888prabhu rgsl888prabhu merged commit 0f0c6a3 into NVIDIA:branch-25.05 Jun 10, 2025
45 checks passed
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
<!--

Thank you for contributing to cuOpt :)

Here are some guidelines to help the review process go smoothly.

1. Please write a description in this text box of the changes that are
being
   made.

2. Please ensure that you have written units tests for the changes
made/features
   added.

3. If you are closing an issue please use one of the automatic closing
words as
noted here:
https://help.github.com/articles/closing-issues-using-keywords/

4. If your pull request is not ready for review but you want to make use
of the
continuous integration testing facilities please label it with `[WIP]`.

5. If your pull request is ready to be reviewed without requiring
additional
work on top of it, then remove the `[WIP]` label (if present) and
replace
it with `[REVIEW]`. If assistance is required to complete the
functionality,
for example when the C/C++ code of a feature is complete but Python
bindings
are still required, then add the label `[HELP-REQ]` so that others can
triage
and assist. The additional changes then can be implemented on top of the
same PR. If the assistance is done by members of the rapidsAI team, then
no
additional actions are required by the creator of the original PR for
this,
otherwise the original author of the PR needs to give permission to the
person(s) assisting to commit to their personal fork of the project. If
that
doesn't happen then a new PR based on the code of the original PR can be
opened by the person assisting, which then will be the PR that will be
   merged.

6. Once all work has been done and review has taken place please do not
add
features or make changes out of the scope of those requested by the
reviewer
(doing this just add delays as already reviewed code ends up having to
be
re-reviewed/it is hard to tell what is new etc!). Further, please do not
rebase your branch on main/force push/rewrite history, doing any of
these
   causes the context of any comments made by reviewers to be lost. If
   conflicts occur against main they should be resolved by merging main
   into the branch used for making the pull request.

Many thanks in advance for your cooperation!

-->
Minor doc fix to ensure commands to fetch test datasets are instructed
to be run the right working directory.

closes NVIDIA#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants