Skip to content

Fix race condition in add_external_solutions_to_population #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Feb 27, 2026
Merged

Fix race condition in add_external_solutions_to_population #909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ad1a9
fix race condition in add_external_solutions_to_population
akifcorduk Feb 27, 2026
df78b71
revert mutex and only remove the early return check
akifcorduk Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cpp/src/mip_heuristics/diversity/population.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,7 @@ void population_t<i_t, f_t>::add_external_solution(const std::vector<f_t>& solut
template <typename i_t, typename f_t>
void population_t<i_t, f_t>::add_external_solutions_to_population()
{
// early exit to avoid taking the population lock
if (!solutions_in_external_queue_.load()) { return; }

// don't do early exit checks here. mutex needs to be acquired to prevent race conditions
auto new_sol_vector = get_external_solutions();
add_solutions_from_vec(std::move(new_sol_vector));
}
Expand Down