Add missing thrust headers across C++ sources#997
Add missing thrust headers across C++ sources#997rapids-bot[bot] merged 4 commits intoNVIDIA:mainfrom
Conversation
|
Separately from this PR, cuOpt should move to using the newer fancy iterator classes from |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds missing Thrust header includes and a few SPDX year updates across many CUDA source and header files to restore direct dependencies (zip/transform iterators, tuple, extrema, transform_reduce, device_ptr, etc.). It also makes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Direct #include directives for thrust iterator, tuple, functional, and algorithm headers that were previously resolved only through transitive includes. The immediate failure was make_transform_output_iterator in infeasibility_information.cu (CI build error with CUDA 13.1.1); this commit adds the explicit includes for every thrust symbol used across all .cu/.cuh/.hpp files to prevent similar breakage when transitive paths change. Signed-off-by: Bradley Dice <bdice@bradleydice.com>
4c3b1d8 to
d80c581
Compare
| { | ||
| "version": "26.04.00", | ||
| "url": "https://docs.nvidia.com/cuopt/user-guide/26.04.00/", | ||
| "version": "26.06.00", |
There was a problem hiding this comment.
Is this change intended? Seems unrelated and I don't know what this json conf does
There was a problem hiding this comment.
This is used for switching docs from one release version to another. Somehow, it was missed or this branch was outdated in some way. And check style ensures all these versions are upto-date per release version.
There was a problem hiding this comment.
This was required by cuOpt's pre-commit hooks. Without this, the style checks failed on main.
I would have expected main to already contain these changes, since #975 bumped VERSION to 26.06.00.
Perhaps developers are still targeting release/26.04 and haven't noticed that main has been broken?
vyasr
left a comment
There was a problem hiding this comment.
Approving the switch of cuopt_cli to compiling with position independent code.
|
/merge |
Description
Fixes CI build failure where
thrust::make_transform_output_iteratorwas not found ininfeasibility_information.cuwhen building with CUDA 13.1.1 (CI log).The codebase relied on transitive includes to resolve thrust symbols. This PR applies the Include What You Use (IWYU) principle: each of the 45 affected
.cu/.cuh/.hppfiles now directly includes the thrust headers for symbols it uses (transform_iterator.h,transform_output_iterator.h,zip_iterator.h,tuple.h,device_ptr.h,transform_reduce.h,extrema.h).Issue
Closes #996
Checklist