Skip to content

Fix NVDriver templating #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArangoGutierrez merged 1 commit into from
Jul 17, 2025
Merged

Fix NVDriver templating #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pkg/provisioner/templates/nv-driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import (
"github.com/NVIDIA/holodeck/api/holodeck/v1alpha1"
)

const defaultNVBranch = "575"

// From https://docs.nvidia.com/datacenter/tesla/tesla-installation-notes/index.html#ubuntu-lts
const NvDriverTemplate = `
# Install Dependencies
Expand Down Expand Up @@ -61,10 +63,14 @@ type NvDriver v1alpha1.NVIDIADriver
func NewNvDriver(env v1alpha1.Environment) *NvDriver {
var nvDriver NvDriver

// Propagate user-supplied settings
nvDriver.Install = env.Spec.NVIDIADriver.Install
nvDriver.Branch = env.Spec.NVIDIADriver.Branch
nvDriver.Version = env.Spec.NVIDIADriver.Version

if env.Spec.NVIDIADriver.Branch == "" {
nvDriver.Branch = "575"
// Apply default branch only when neither a specific version nor a branch was provided
if nvDriver.Version == "" && nvDriver.Branch == "" {
nvDriver.Branch = defaultNVBranch
}

return &nvDriver
Expand Down
Loading