Skip to content

[no-relnote] fix aws security ground create #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArangoGutierrez merged 1 commit into from
Jul 30, 2025
Merged

[no-relnote] fix aws security ground create #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pkg/provider/aws/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,22 +249,30 @@ func (p *Provider) createSecurityGroup(cache *AWS) error {
cache.SecurityGroupid = *sgOutput.GroupId

// Enter the Ingress rules for the security group
ipRangeMap := make(map[string]bool)
ipRanges := []types.IpRange{}

// First lookup for the IP address of the user
ip, err := utils.GetIPAddress()
if err != nil {
p.fail()
return fmt.Errorf("error getting IP address: %v", err)
}

// Add the auto-detected IP to the map and list
ipRangeMap[ip] = true
ipRanges = append(ipRanges, types.IpRange{
CidrIp: &ip,
})

// Then add the IP ranges from the spec
// Then add the IP ranges from the spec, skipping duplicates
for _, ip := range p.Spec.IngressIpRanges {
ipRanges = append(ipRanges, types.IpRange{
CidrIp: &ip,
})
if !ipRangeMap[ip] {
ipRangeMap[ip] = true
ipRanges = append(ipRanges, types.IpRange{
CidrIp: &ip,
})
}
}

irInput := &ec2.AuthorizeSecurityGroupIngressInput{
Expand Down
Loading