feat(templates): add RPM support to NVIDIA driver#676
Merged
ArangoGutierrez merged 2 commits intoNVIDIA:mainfrom Feb 18, 2026
Merged
feat(templates): add RPM support to NVIDIA driver#676ArangoGutierrez merged 2 commits intoNVIDIA:mainfrom
ArangoGutierrez merged 2 commits intoNVIDIA:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds RPM-based distribution support to the NVIDIA driver provisioning templates, enabling Holodeck to work with distributions like Rocky Linux, Amazon Linux, RHEL, and Fedora alongside existing Debian/Ubuntu support.
Changes:
- Added OS-family detection and branching logic to package, runfile, and git driver installation templates
- Implemented RPM-specific package management (kernel-devel, gcc-c++, dnf) alongside existing Debian patterns (linux-headers, build-essential, apt)
- Added CUDA repository setup for RPM distributions with distro-specific mapping logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/provisioner/templates/nv-driver.go | Added OS family branching (debian vs amazon/rhel) to all three driver templates with RPM package names, CUDA repo setup via .repo files, and RPM version pinning syntax |
| pkg/provisioner/templates/nv-driver_test.go | Added comprehensive test coverage for RPM support including OS family branching, kernel headers, build dependencies, and CUDA repository setup |
Add OS-family branching to all three driver templates (package, runfile,
git) so they work on RPM-based distributions (Rocky Linux 9, Amazon
Linux 2023, Fedora, RHEL 9) in addition to Debian/Ubuntu.
Key changes per template section:
- Kernel headers: linux-headers -> kernel-devel + kernel-headers (RPM)
- Build deps: build-essential/libelf-dev/libglvnd-dev ->
elfutils-libelf-devel/mesa-libEGL-devel/gcc-c++ (RPM)
- CUDA repo: .deb keyring -> .repo file with distro mapping
(rhel9/fedora/amzn->rhel9)
- Package versioning: =VERSION (apt) vs -VERSION (dnf)
- Package cache: apt-get update -> pkg_update (RPM)
Follows the established pattern from containerd.go using
case "${HOLODECK_OS_FAMILY}" in debian|amazon|rhel branching.
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
rpm-support/nvidia-driver
branch
from
209930c to
caf03ac
Compare
&>/dev/null already redirects both stdout and stderr; the extra 2>&1 is a no-op. Flagged by Copilot review. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 22147036492Details
💛 - Coveralls |
24 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=version pinning-version pinningpkg_updateabstraction consistently across all branchesPart of #569 (Epic: Support RPM-Based Distributions)
Test plan
go test ./pkg/provisioner/templates/ -count=1passes