feat(validate): add custom template input validation (#565)#703
Merged
ArangoGutierrez merged 2 commits intoNVIDIA:mainfrom Mar 5, 2026
Merged
Conversation
Validates template name, phase, source exclusivity, URL scheme (HTTPS only), file path safety (including path traversal), checksum format (sha256), and duplicate names. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 22684960905Details
💛 - Coveralls |
NVIDIA#565) Address review feedback on PR NVIDIA#703: - R1: Validate env var keys against [a-zA-Z_][a-zA-Z0-9_]* to prevent command injection via export statements in the executor - R2: Check for ".." as a path component (split on "/") instead of substring match, allowing legitimate filenames like "foo..bar.sh" Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateCustomTemplates()to validate user-supplied custom templates before shell interpolationValidateTemplateInputs()pipelineTest plan
go build ./...passesgo vet ./...passes