ci: update periodic cleanup to v0.3.1#765
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Mar 31, 2026
Merged
Conversation
v0.3.1 includes NLB cleanup in DeleteVPCResources, which is needed to clean up VPCs that have NLB resources blocking deletion. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 23811383927Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the periodic cleanup workflow to use
NVIDIA/holodeck@v0.3.1, which includes NLB cleanup inDeleteVPCResources.Problem: The cleanup job was using
@v0.3.0which doesn't know how to delete NLB resources (load balancers, target groups, listeners). VPCs with NLBs fail withDependencyViolationbecause NLB-owned ENIs block subnet/IGW/VPC deletion.Evidence: Run #554 failed — 0/11 us-west-1 VPCs cleaned: https://github.com/NVIDIA/holodeck/actions/runs/23808669540
Fix: One-line change:
@v0.3.0→@v0.3.1