fix: treat InvalidVpcID.NotFound as success in VPC cleanup#769
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Apr 1, 2026
Merged
Conversation
When the Docker action's post-entrypoint re-runs cleanup, VPCs deleted in the main step are already gone. Treat InvalidVpcID.NotFound as success instead of retrying 3 times and failing. Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Pull Request Test Coverage Report for Build 23841329015Details
💛 - Coveralls |
This was referenced Apr 1, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The periodic cleanup action fails because the Docker action's
post-entrypointre-runs cleanup on VPCs that were already deleted in the main step. ThedeleteVPCfunction retries 3 times onInvalidVpcID.NotFoundinstead of treating it as success.Root Cause
action.ymlhaspost-entrypoint: 'holodeck'which re-executes the cleanup binary in the post phase. By then, VPCs are already gone →InvalidVpcID.NotFound→ 3 retries → failure.Fix
Treat
InvalidVpcID.NotFoundas success indeleteVPC(), matching the existing pattern inpkg/provider/aws/delete.go:479. If the VPC doesn't exist, cleanup succeeded.Also Needed (IAM - manual)
The
cnt-ciIAM user is missingec2:RevokeSecurityGroupIngressandec2:RevokeSecurityGroupEgresspermissions. Without these, the SG cross-reference fix (#766) can only log warnings. This needs to be added to the IAM policy.Testing
should treat InvalidVpcID.NotFound as success