feat(health): NVUE gNMI streaming collector + OTLP metrics export#1097
Draft
mkoci wants to merge 6 commits intoNVIDIA:mainfrom
Draft
feat(health): NVUE gNMI streaming collector + OTLP metrics export#1097mkoci wants to merge 6 commits intoNVIDIA:mainfrom
mkoci wants to merge 6 commits intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
Signed-off-by: mkoci <mkoci@nvidia.com>
mkoci
force-pushed
the
feature/gnmi_streaming
branch
from
0648153 to
1c442ee
Compare
Collaborator
Contributor
Author
# Conflicts: # Cargo.lock # crates/health/src/sink/otlp.rs
mkoci
force-pushed
the
feature/gnmi_streaming
branch
from
e1f2701 to
7c9e28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds NVOS gRPC switch node streaming telemetry collection for NVLink Switches to the health service, plus OTLP metric export so the high-cardinality switch data can push to an OTel Collector instead of accumulating in Prometheus gauges.
gNMI collector (
[collectors.nvue.gnmi], disabled by default) subscribes to gNMI SAMPLE paths for/components,/interfaces, and/leak-sensors. It uses a long-lived bidirectional gRPC stream with reconnection support (exponential backoff + jitter) and fits into the existing discovery/sharding loop with proper spawn, cleanup, and cancellation. Metrics flow through the normalDataSinkpipeline — no parallelGaugeVecregistration.OTLP metrics export extends
OtlpSink(introduced in #711 for logs) with aMetricsServicedrain alongside the existingLogsServicedrain. Both share one OTel Collector endpoint but use separate queues and drain tasks.PrometheusSinkstays in the composite during the migration period so/metricskeeps serving.Builds on #711 (SSE streaming + OtlpSink for logs). Protos vendored for reproducible offline builds, same as #711.
Type of Change
Related Issues
Breaking Changes
Testing
Additional Notes
AcceptAnyCertVerifierintls.rs), but traffic remains encrypted. Code changes will be needed after we properly manage and install TLS certificates during switch configuration.StreamingConnectionGuard(RAII inc/dec on the per-streamconnectedgauge) from feat(health): SSE streaming log support. OtlpSink. FileSync #711 is generalized here — the gNMI subscriber constructs one scoped to the READY phase of its gRPC stream so Drop covers every exit path.Collector::spawn_taskis a new generic spawn helper for streaming collectors that don't fit theStreamingCollectortrait shape (gNMI subscriptions are bidirectional and multiplex paths on a single stream).