Add KeyRerotationPress#31
Merged
maxjeblick merged 25 commits intomainfrom Dec 12, 2024
Merged
Conversation
Collaborator
Author
|
@giulio98 feel free to comment on this PR if you have any observations. |
Collaborator
Author
|
I should mention that |
# Conflicts: # tests/presses/test_presses.py
Merged
SimJeg
reviewed
Dec 11, 2024
SimJeg
reviewed
Dec 11, 2024
SimJeg
reviewed
Dec 11, 2024
SimJeg
reviewed
Dec 11, 2024
SimJeg
reviewed
Dec 11, 2024
SimJeg
reviewed
Dec 12, 2024
SimJeg
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
KeyRerotationPresswhich allows to apply key rerotation to any press that inherits fromScorerPress.I added a relatively lengthy test to ensure that
RoPE * prune * RoPE^-1 * RoPE * keysis numerically equivalent toRoPE * prune * keys(which wasn't obvious to me).Fixes #16