Skip to content

skip invoking toolkit.Install when NRI Plugin is enabled #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tariq1890 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

skip invoking toolkit.Install when NRI Plugin is enabled #1754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cmd/nvidia-ctk-installer/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,14 @@ func (a *app) Run(ctx context.Context, c *cli.Command, o *options) error {
o.toolkitOptions.ContainerRuntimeRuntimes = lowlevelRuntimePaths
}

err = a.toolkit.Install(c, &o.toolkitOptions, o.runtime)
if err != nil {
return fmt.Errorf("unable to install toolkit: %v", err)
// Skip installing toolkit artifacts if NRI Plugin is enabled. This allows for the switch to transition to NRI plugin
// mode in an already running cluster, as the previous toolkit config toml can continue to be used. This is required
// when deleting pods that reference the runtime classes made stale since the switch to NRI Plugin mode.
if !o.enableNRIPlugin {
err = a.toolkit.Install(c, &o.toolkitOptions, o.runtime)
if err != nil {
return fmt.Errorf("unable to install toolkit: %w", err)
}
}

err = runtimeConfigurer.Setup(c, &o.runtimeOptions)
Expand Down
Loading