Skip to content

Add Dynamo (ai-dynamo/dynamo) to skill catalog and CI sync check#12

Open
shljessie wants to merge 1 commit intoNVIDIA:mainfrom
shljessie:add-dynamo-skills
Open

Add Dynamo (ai-dynamo/dynamo) to skill catalog and CI sync check#12
shljessie wants to merge 1 commit intoNVIDIA:mainfrom
shljessie:add-dynamo-skills

Conversation

@shljessie
Copy link
Copy Markdown
Contributor

No description provided.

@shljessie shljessie requested a review from mosheabr as a code owner April 13, 2026 21:33
@mosheabr
Copy link
Copy Markdown
Collaborator

Thanks for adding Dynamo — the skill count (8) checks out against the source repo. A few things before we can merge:

1. Org ownershipai-dynamo is not under an NVIDIA org (NVIDIA/, NVIDIA-NeMo/, NVIDIA-AI-Blueprints/). All other products in the catalog are hosted under NVIDIA-owned GitHub orgs. Can you clarify the relationship? If this is an NVIDIA project, it should be moved or transferred to an NVIDIA org before we add it to the official catalog. This is important for provenance and trust — the catalog represents NVIDIA-published skills.

2. Sync workflow — This PR adds Dynamo to the CI count check and README, but not to sync-skills.yml. Dynamo needs a corresponding block in the sync workflow so skills are mirrored into the catalog automatically. Can you add that in this PR?

3. CI failure — The CI failure is not caused by this PR. Megatron-Bridge added a 9th skill (resiliency) upstream but the expected count in ci.yml is still 8. I'll fix that separately so it doesn't block you. Your Dynamo count of 8 is accurate.

Please address #1 and #2 and I'll get #3 unblocked on my end.

@mosheabr
Copy link
Copy Markdown
Collaborator

@shljessie — following up on the earlier review. The org ownership question is still the main blocker here. Can you clarify whether ai-dynamo is an NVIDIA-owned org or plans to move under one?

Also heads up — PR #19 is about to land which replaces ci.yml with a config-driven products.yml. Once that merges, the ci.yml change in this PR won't be needed. Instead you'd just add a Dynamo entry to products.yml and the sync workflow picks it up automatically. Might be easier to rebase on top of that.

Let me know on the org question and we can get this moving.

@shljessie
Copy link
Copy Markdown
Contributor Author

@mosheabr ai-dynamo is an NVIDIA owned product but they have moved under an ai-dynamo org name. So my opinion is that it does fit into the NVIDIA org. But bringing Ben Hamm (PM) into the conversation.

@shljessie
Copy link
Copy Markdown
Contributor Author

@mosheabr Update on this after talking to Ben, current state of dynamo skills are still in progress so we will close this PR for now!

@shljessie shljessie closed this Apr 16, 2026
@shljessie shljessie reopened this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants