Skip to content

docs: fix list basic type#17

Merged
Naapperas merged 1 commit intoNaapperas:developfrom
cachho:docs/FixReadme
Feb 5, 2025
Merged

docs: fix list basic type#17
Naapperas merged 1 commit intoNaapperas:developfrom
cachho:docs/FixReadme

Conversation

@cachho
Copy link
Copy Markdown
Contributor

@cachho cachho commented Feb 5, 2025

fix the readme to refer to the correct list/array basic type.

@cachho
Copy link
Copy Markdown
Contributor Author

cachho commented Feb 5, 2025

I'm also curious why it's not just called list? because that's a protected name?

@Naapperas
Copy link
Copy Markdown
Owner

I'm also curious why it's not just called list? because that's a protected name?

It's not so much a protected name but a built-in class you can use, and if I implemented that method as list, when the module would be loaded, to the best of my knowledge I would be overriding the actual list constructor.

I might be wrong on this: if so, please point me to where you found out I was wrong so I can also learn.

@cachho
Copy link
Copy Markdown
Contributor Author

cachho commented Feb 5, 2025

I'm not saying you are wrong. Sounds plausible. I was just curious and that's a valid reason.

@Naapperas
Copy link
Copy Markdown
Owner

I'm not saying you are wrong. Sounds plausible. I was just curious and that's a valid reason.

Bad phrasing, I meant to say that if you eventually found I was wrong to point me to the right resources.

Eitherway, thank you for the contribution :)

@Naapperas Naapperas merged commit b721add into Naapperas:develop Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants