Skip to content

docs: chaining#19

Closed
cachho wants to merge 1 commit intoNaapperas:developfrom
cachho:docs/Chaining
Closed

docs: chaining#19
cachho wants to merge 1 commit intoNaapperas:developfrom
cachho:docs/Chaining

Conversation

@cachho
Copy link
Copy Markdown
Contributor

@cachho cachho commented Feb 5, 2025

I personally find this syntax much better, especially when using nested validators, like list or record.

But I guess you could also argue that it's a natural part of python and doesn't have to be explained in the docs.

Copy link
Copy Markdown
Owner

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I just assumed people would naturally do it and didn't even remember to put it on the README but it is in fact something that by all means should be there. Just added a small correction that needs to be made.

Comment thread README.md
Naapperas
Naapperas previously approved these changes Feb 5, 2025
@Naapperas
Copy link
Copy Markdown
Owner

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

@cachho
Copy link
Copy Markdown
Contributor Author

cachho commented Feb 12, 2025

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

can you check if that's fine for you? Really not an expert on this.

@Naapperas
Copy link
Copy Markdown
Owner

Naapperas commented Mar 3, 2025

Great PR. Could you perhaps rebase this branch against develop so we don't pull in that merge commit? Just a nitpick on my end, the PR itself is ready to be merged into develop.

can you check if that's fine for you? Really not an expert on this.

All set for this PR We lost the requested change. If you wish I can take care of it, you'll still get the credit for the work. Note that, with the merging of your latest PR, the README now has conflicts. Shouldn't take much to resolve.

@Naapperas
Copy link
Copy Markdown
Owner

Naapperas commented May 16, 2025

@cachho Any updates on this? I am planning on releasing a new version in a bit. I'll wait a bit and then will myself implement your changes. You'll still get credited.

@Naapperas
Copy link
Copy Markdown
Owner

Closed in #23

@Naapperas Naapperas closed this May 16, 2025
@cachho
Copy link
Copy Markdown
Contributor Author

cachho commented May 17, 2025

sorry, yeah I was busy :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants