Skip to content

Data setup#11

Merged
egonw merged 19 commits intoNanoCommons:mainfrom
egonw:data-setup
Jan 11, 2024
Merged

Data setup#11
egonw merged 19 commits intoNanoCommons:mainfrom
egonw:data-setup

Conversation

@egonw
Copy link
Copy Markdown
Contributor

@egonw egonw commented Jan 9, 2024

Based on @jmillanacosta's PR #10, but with my later commits and, particularly, open again.

To be done:

  • custom workflow, to overcome the limited set up supported gems by GitHub Pages
  • fix the work page generation, and remove the original work/ folder

And ideally, have:

  • /substance/ERM/ERM00xxxx instead of /substance/ERM/00xxxx

@jmillanacosta
Copy link
Copy Markdown
Collaborator

jmillanacosta commented Jan 10, 2024

Not sure why, but the jekyll-datapage-generator plugin does not let me capitalize the name_expr for generating pages (https://github.com/avillafiorita/jekyll-datapage_gen/blob/e2585a297cfe0e517c26c61673031e2a51d4b203/lib/jekyll-datapage-generator.rb#L17)

image
The htmls on the side are the jekyll-generated /substance/erm/ pages from the instructions in the yaml, notice erm is not capitalized. Hence the 'patchy' approach from my original fork (ERM/000000 instead of erm00000), which I understand is not ideal either.

What should we do if this capitalization issue is not solvable with this plugin? Identifier consistency is a pretty big deal.

@jmillanacosta
Copy link
Copy Markdown
Collaborator

jmillanacosta commented Jan 10, 2024

Not sure why, but the jekyll-datapage-generator plugin does not let me capitalize the name_expr for generating pages.

image The htmls on the side are the jekyll-generated /substance/erm/ pages from the instructions in the yaml, notice erm is not capitalized. Hence the 'patchy' approach from my original fork (ERM/000000 instead of erm00000), which I understand is not ideal either.

What should we do if this capitalization issue is not solvable with this plugin? Identifier consistency is a pretty big deal.

#60e8b34 and #7f28fdd solve this issue with a custom workflow.

@egonw can you enable pages from GitHub actions from your branch (egonw/erm-database/) to check if it deploys correctly to https://egonw.github.io/erm-database ?

@jmillanacosta
Copy link
Copy Markdown
Collaborator

@egonw I need help to understand what's the issue with work pages you mentioned: the pages are correctly built locally for me, e.g. http://127.0.0.1:4000/erm-database/work/10.1186/S13321-022-00614-7 shows me a nice-looking page for that resource with all the features.

What didn't work for you?

@egonw egonw merged commit 7826d77 into NanoCommons:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants