-
Notifications
You must be signed in to change notification settings - Fork 29
Add sidewall angle parameter #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
1702815
added sidewall_angle property in scheme
danielwboyce ff0dfa8
changes to add sidewall_angle
danielwboyce d6fb958
started trying to add transformation matrix but realized it may not b…
danielwboyce d4e35b2
Coordinate transform functions have been updated to account for a non…
danielwboyce 2ff3d4a
The prism_projective_transformation_for_* functions won't work on pri…
danielwboyce a18601f
Added another unit test to save prisms with and without normal sidewa…
danielwboyce ff33e65
Fixed a compilation error
danielwboyce b7ce926
Fixed a compilation error
danielwboyce 5c37bd0
Reverted changes to prism_coordinate_p2c(), prism_vector_p2c(), prism…
danielwboyce 6564979
* Addition of some derived values. This will increase the memory usag…
danielwboyce 030a133
Calculated difference vectors in init_prism()
danielwboyce 55e3871
Correction for case where sidewall_angle==0 (would have blown up tang…
danielwboyce c9c7421
Correction to point_in_or_on_prism().
danielwboyce 078b476
Update to prism2gnuplot() so that it will work with any sidewall angle
danielwboyce fcbfade
Updates for prism2gnuplot()
danielwboyce e83f334
Update to cx and cy calculations for accuracy
danielwboyce eb66a05
Update to prism2gnuplot()
danielwboyce f17fc40
* Changed vertices to vertices_bottom and vertices_p to vertices_bott…
danielwboyce be2b578
Changes to some comments for unity.
danielwboyce 093ec84
Fixes for correct compilation.
danielwboyce ca17957
* Calculations for vertices_top and vertices_top_p.
danielwboyce 24124dc
Update to get_prism_bounding_box for compatibility with top polygon f…
danielwboyce 72462b4
Update to intersect_line_with_prism for compatibility with top polygo…
danielwboyce d37689f
Update to geom_object_volume for compatibility with top polygon frame…
danielwboyce d2e2868
oops
danielwboyce 0dc29b0
Update to min_distance_to_prism_roof_or_ceiling for compatibility in …
danielwboyce 8d5eb91
Rough draft of algorithm where offset of the top polygon's edges is f…
danielwboyce f43f128
Updates to the comments
danielwboyce 4e830ed
Fixed typo (was using abs instead of fabs)
danielwboyce 0daf5b6
Update to run unit test 5 in test-prism.c with concave octagonal c shape
danielwboyce 17f97a3
Update to calculate prism volume with the triangular wedges trick.
danielwboyce 2256149
Update for memory fix and to print volumes
danielwboyce 31b0ec8
Changed proportions of test geometry.
danielwboyce dc0cc1d
Merge branch 'master' of https://github.com/NanoComp/libctl into meep…
danielwboyce 2164d7f
Removes some unused properties of prism that were created during side…
danielwboyce 60da7fd
Split fifth unit test into two separate ones.
danielwboyce d29e887
* Began restructuring of unit testing of helper functions
danielwboyce 679af4b
Reorganized results string
danielwboyce 9e6258e
Added some test points, but should probably rethink them.
danielwboyce 61ee5ec
* Change to intersect_line_with_segment so that fabs(detM)<=0 instead…
danielwboyce 22b2703
Finalized point_in_prism test points for normal sidewall; all pass.
danielwboyce 53585b0
Finalized point_in_prism test points for tapered sidewall; all pass.
danielwboyce a48dd78
Slight change to intersect_line_with_segment so that q0 that is withi…
danielwboyce 8642953
Shift of relative_error definition location
danielwboyce 0e60ea2
Change to how failing test results are presented
danielwboyce 23ec85f
Tuning min_distance_to_prism_roof_or_ceiling for new sidewall scheme
danielwboyce 311318b
Addition of test points for testing normal_to_prism
danielwboyce 6ced328
Removed some extraneous comments
danielwboyce b690303
Draft version of intersect_line_with_prism where the vector equation …
danielwboyce fafc493
Typo in RHS definition in intersect_line_with_prism (had dp instead o…
danielwboyce de626f2
Update to intersect_line_with_prism so that num_intersections is pass…
danielwboyce 4dba674
Commit backing up extraneous unit test.
danielwboyce fa248c0
Removing extra unit test.
danielwboyce 9a49056
One test so far in test-prism for intersect_line_segment_with_prism
danielwboyce 394b9b9
typo
danielwboyce 6050f55
addition of more tests
danielwboyce b645db6
Additional of final test points, which now all pass.
danielwboyce 3d5d42e
Change to init_prism so that it is no longer O(n^2)
danielwboyce 74664f6
Add Daniel as a contributor
danielwboyce ec44c2c
Remove isnan check
danielwboyce 629f02d
Change offset definition to be simpler
danielwboyce 30ed679
Addition of make_slanted_prism_with_center to maintain ABI compatibility
danielwboyce 2df3673
Fixed some typos
danielwboyce af95319
Didn't maintain ABI compatibility, should be now. User uses make_slan…
danielwboyce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.