Restore some C89 compliance (variable declarations in for loops)#54
Merged
stevengj merged 2 commits intoNanoComp:masterfrom Feb 13, 2020
Merged
Restore some C89 compliance (variable declarations in for loops)#54stevengj merged 2 commits intoNanoComp:masterfrom
stevengj merged 2 commits intoNanoComp:masterfrom
Conversation
Collaborator
|
The For test programs etcetera we control the compiler flags so we can use C99 features there if we want. If we rely on C99 features for the test programs we should probably have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #53 (comment) and get CI back for MPB.
There are a lot of variable declarations in
utils/test-prism.cthat are not at the beginning of blocks; I think that is nominally not C89/90 compliant, but if I understand correctly it should not be a problem under gcc.Thus, I just restricted myself to fixing the declarations inside loop blocks.
I also added an exclusion of .dat files to
.gitignore, which are generated when running the libctl checks now.