remove unused function output_mode_fields#1367
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Sep 23, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the function
fields::output_mode_fieldswhich was added in #192 but seems to no longer be used. This function is intended to output to an HDF5 file the eigenmode fields obtained from callingget_eigenmodebut does not seem to be implemented correctly since it never writes anything to a file and requires adft_fluxargument which is unnecessary. It's also missing a (high-level) Python interface.(If we do want such a function then we will need to fix these bugs and provide a Python interface.)