abort get_dft_array if user-supplied frequency index is invalid#1373
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Oct 2, 2020
Merged
abort get_dft_array if user-supplied frequency index is invalid#1373stevengj merged 1 commit intoNanoComp:masterfrom
stevengj merged 1 commit intoNanoComp:masterfrom
Conversation
Collaborator
|
(Following this comment: #1368 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the frequency index parameter
num_freqofget_dft_arrayis outside the valid range (e.g., ifnum_freqis larger than the size of the array), the function returns an array of zero values which is incorrect. This PR adds a check indft_chunk::process_dft_componentto verify thatnum_freqis valid, otherwise it aborts with an error.