Closed
Conversation
Added checks in update_P: check, whether there is a diagonal element before you add contributions from off-diagonal elements. This avoids instabilities at boundaries for non-diagonal sigma.
stevengj
reviewed
Mar 20, 2018
| LOOP_OVER_VOL_OWNED(gv, c, i) { | ||
| LOOP_OVER_VOL_OWNED(gv, c, i) if(s[i]!=0) { | ||
| //"if" to avoid instabilities coming from yee-grid shifts of off-diagnal elements | ||
| + //FIXME: this prevents materials with pure off-diagonal sigma from working |
Collaborator
There was a problem hiding this comment.
Wouldn't a purely off-diagonal sigma matrix be indefinite, and hence lead to both loss and gain?
stevengj
reviewed
Mar 20, 2018
| + OFFDIAG(s2,w2,is2,is))); | ||
| pp[i] = pcur; | ||
| }else{ | ||
| p[i]=0; //seems unnecessary, but no harm is done here |
Collaborator
There was a problem hiding this comment.
Delete the else clause, since p[i] is initialized to zero anyway.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks in update_P: check, whether there is a diagonal element before you add contributions from off-diagonal elements. This avoids instabilities at boundaries for non-diagonal sigma.