Skip to content

Replace blocks with prism in mode-decomposition.py#369

Merged
stevengj merged 1 commit intoNanoComp:masterfrom
ChristopherHogan:chogan/md_prism
Jun 8, 2018
Merged

Replace blocks with prism in mode-decomposition.py#369
stevengj merged 1 commit intoNanoComp:masterfrom
ChristopherHogan:chogan/md_prism

Conversation

@ChristopherHogan
Copy link
Contributor

This was a request from Ardavan.
@stevengj @oskooi

@DerekK44
Copy link
Contributor

DerekK44 commented Jun 7, 2018

As a meep user, thank you! Would it be possible to get the prism type added to the Python user interface as well (either in this or perhaps a separate PR)?

@ChristopherHogan
Copy link
Contributor Author

The prism type for Python was merged in #345.

@DerekK44
Copy link
Contributor

DerekK44 commented Jun 7, 2018

Ah, I was referring to the documentation for the Python user interface (specifically Python_User_Interface.md). Now that the prism type is added it would be great for users to know the correct function inputs.

Thanks for all these great additions to meep!

@ChristopherHogan
Copy link
Contributor Author

Oh, I see. Yes, we'll get documentation up very soon.

@stevengj stevengj merged commit 2b3b361 into NanoComp:master Jun 8, 2018
@ChristopherHogan ChristopherHogan deleted the chogan/md_prism branch June 13, 2018 14:37
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants