You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realized that the changes from #134 broke make check when compiled with MPI, because the symmetry-eigenvalue tests would try to run but fail because the code throws a transformed_overlap(..) is not yet implemented for MPI error.
This just disables that check if (using-mpi?) is true.
Coincidentally - and not exactly relatedly, but figured I'd ask while I already have your attention - I have been meaning to ask:
If I wanted to make the compute_symmetry, etc. functions accessible in meep's Python interface for mpb, what would the steps be?
I had naively thought it might be possible to expose the C-functions from MPB via meep's python/solver.py - but looking in libpympb/pympb.cpp, I get the impression that virtually all the Python-accessible MPB methods are reimplemented from scratch there? Is that the only way to go about it, i.e. duplicate everything in the meep repo? (I don't have prior experience with SWIG, unfortunately)
Okay, thanks for clarifying that 👍. I'll try to port the code to the meep repo one of these days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the changes from #134 broke
make checkwhen compiled with MPI, because the symmetry-eigenvalue tests would try to run but fail because the code throws atransformed_overlap(..) is not yet implemented for MPIerror.This just disables that check if
(using-mpi?)is true.