Skip to content

Bug fix of passing array parameter to signal link#23

Merged
aleswita merged 10 commits intoNasExt:masterfrom
aleswita:master
Feb 12, 2018
Merged

Bug fix of passing array parameter to signal link#23
aleswita merged 10 commits intoNasExt:masterfrom
aleswita:master

Conversation

@aleswita
Copy link
Copy Markdown

  • Bug fix of passing array parameter to signal link (can't make dependent select on multiple select box)
$form->addMultiSelect('foo1', 'foo1')
	->setItems([0, 1, 2, 3, 4, 5]);

$form->addDependentMultiSelectBox('foo2', 'foo2', $form['foo1'])
	->setDependentCallback(function (array $values): \NasExt\Forms\Controls\DependentSelectBoxData {
		$data = new \NasExt\Forms\Controls\DependentSelectBoxData;
		return $data;
	});
  • tests improvments
  • change new lines from Windows (CR LF) to Unix (LF)

@aleswita aleswita requested review from duskohu and removed request for duskohu January 30, 2018 07:54
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 98.077% when pulling 6ef7033 on aleswita:master into 17dced8 on NasExt:master.

@aleswita
Copy link
Copy Markdown
Author

@duskohu pls check changes in client side java script

@aleswita aleswita requested a review from duskohu January 30, 2018 08:00
@aleswita aleswita self-assigned this Jan 30, 2018
@aleswita aleswita merged commit 09c616d into NasExt:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants