Open
Conversation
capacity factor for standalone batt
cpaulgilman
approved these changes
Apr 16, 2026
Collaborator
There was a problem hiding this comment.
Thanks for adding the roundtrip efficiency to the Battery Compare Cases macro.
One small fix. The footer says:
This report was generated using the System Advisor Model testMacro on:
It should say
This report was generated using the System Advisor Model Battery Compare Cases macro on:
Also, I got thrown off because there's a "Compare Cases" and a "Battery Compare Cases" macro. As a separate issue, I would recommend combining the macros into a single "Compare Cases" macro that can handle battery and non-battery cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Add roundtrip efficiency in summary table for Battery Compare Cases macro
-To test:
-open attached SAM file
-Simulate both cases
-Go to macros -> Battery Compare Cases, run macro with all cases
-See results
Fixes #1973
batt_macro_test.zip
Checklist