Skip to content

Ssc 1378 custom generation lifetime#1384

Open
brtietz wants to merge 10 commits intodevelopfrom
ssc_1378_custom_generation_lifetime
Open

Ssc 1378 custom generation lifetime#1384
brtietz wants to merge 10 commits intodevelopfrom
ssc_1378_custom_generation_lifetime

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented Apr 6, 2026

Pull Request Template

Description

Add lifetime mode to custom generation profile with appropriate additional data handling

Fixes #1371 and #1378

Corresponding branches and PRs:

ssc_1378_custom_generation_lifetime on SAM NatLabRockies/SAM#2166

Develop of other branches

Unit Test Impact:

New tests to capture derate handling and lifetime mode

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Report for CI Build 24521038201

Coverage increased (+0.007%) to 56.291%

Details

  • Coverage increased (+0.007%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 215 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

215 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
ssc/ssc/cmod_merchantplant_eqns.cpp 90 55.2%
ssc/ssc/common.cpp 88 76.07%
ssc/ssc/cmod_custom_generation.cpp 37 73.19%

Coverage Stats

Coverage Status
Relevant Lines: 121163
Covered Lines: 68204
Line Coverage: 56.29%
Coverage Strength: 3456733.65 hits per line

💛 - Coveralls

brtietz added 3 commits April 14, 2026 08:30
…g subhourly data from running. Update tests to reflect full timeseries
…ability

Gen may be longer than any merchant plant price array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a lifetime input option to custom generation profile plant

2 participants