Skip to content

Conversation

@tgpetrov
Copy link
Contributor

@tgpetrov tgpetrov commented Aug 9, 2019

PR Checklist

What is the current behavior?

There is a NativeScriptHttpModule that uses Angular deprecated APIs

What is the new behavior?

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Related with #1842 .

BREAKING CHANGES:

  • The NativeScriptHttpModule is removed
  • @angular/http is removed from the dependencies

Migration steps:

  • If using NativeScriptHttpModule, replace with NativeScriptHttpClientModule as done here
  • as @angular/http is no longer a peerDependency of nativescript-angular, you can remove if from your dependencies

@cla-bot cla-bot bot added the cla: yes label Aug 9, 2019
@tgpetrov tgpetrov force-pushed the tgpetrov/remove-http-module branch from e837a4b to c12d2e5 Compare August 12, 2019 07:19
@tgpetrov tgpetrov merged commit c6af21d into master Aug 12, 2019
@tgpetrov tgpetrov deleted the tgpetrov/remove-http-module branch August 12, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants