Skip to content

tests: comment tabs tests partially #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elena-p merged 2 commits into from
Oct 14, 2019
Merged

tests: comment tabs tests partially #2015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de85769
tests: comment tabs tests partially
ADjenkov Oct 14, 2019
5efac41
Merge branch 'master' into djenkov/comment-tests
elena-p Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions e2e/nested-router-tab-view/e2e/home-tabs.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,20 @@ describe("home-tabs:", async function () {
await screen.navigateToTabsPage();
await screen.loadedTabs();
await screen.loadedPlayersList();
await screen.navigateToAboutPage();
await screen.loadedAbout();
await screen.loadedNestedAbout();

// TO DO: This is related to the tns-core-modules animations overhaul intiative (removing Animators in favor of androidx Transitions)
// Angular test case: navigating from Page with 3 nested frames and back crashes with "IllegalArgumentException: parameter must be a descendant of this view" only from these commented appium tests (does not reproduce with manual testing). This is fixed in androidx.fragment:fragment:1.2.0 and tests must be uncommented when migrating to it.
// await screen.navigateToAboutPage();
// await screen.loadedAbout();
// await screen.loadedNestedAbout();
});

it("should go back to Tabs and then back to Home", async function () {
await backActivatedRoute(driver);
await screen.loadedTabs();
await screen.loadedPlayersList();
// TO DO: This is related to the tns-core-modules animations overhaul intiative (removing Animators in favor of androidx Transitions)
// Angular test case: navigating from Page with 3 nested frames and back crashes with "IllegalArgumentException: parameter must be a descendant of this view" only from these commented appium tests (does not reproduce with manual testing). This is fixed in androidx.fragment:fragment:1.2.0 and tests must be uncommented when migrating to it.
// await backActivatedRoute(driver);
// await screen.loadedTabs();
// await screen.loadedPlayersList();
await backActivatedRoute(driver);
await screen.loadedHome();
await screen.loadedPlayersList();
Expand Down