Skip to content

fix: local development workflow errors #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbozhikov merged 3 commits into from
Oct 22, 2019
Merged

fix: local development workflow errors #2028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09bf9ba
fix: local development workflow errors
tbozhikov Oct 22, 2019
d7c6f90
fix: expose missing export for TemplatedItemsComponent
tbozhikov Oct 22, 2019
bb378eb
fix: add additional path for export of templated-items-comp
tbozhikov Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion e2e/animation-examples/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/modal-navigation-ng/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
2 changes: 1 addition & 1 deletion e2e/nested-router-tab-view/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { routerTraceCategory } from "nativescript-angular/trace";
// addCategories(routerTraceCategory);
traceEnable();

class MyErrorHandler implements ErrorHandler {
export class MyErrorHandler implements ErrorHandler {
handleError(error) {
console.log("### ErrorHandler Error: " + error.toString());
console.log("### ErrorHandler Stack: " + error.stack);
Expand Down
2 changes: 1 addition & 1 deletion e2e/nested-router-tab-view/app/modal-second/modal-second.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Label class="action-bar-title" text="Modal Second"></Label>
</ActionBar>

<GridLayout #rootLayout rows="auto, auto" (loaded)="onLoaded($event)">
<GridLayout #rootLayout rows="auto, auto" (loaded)="onLoaded()">
<Button text="Go Back(activatedRoute)" (tap)="goBack()"></Button>
<Button row="1" text="Close Modal" (tap)="close(rootLayout)"></Button>
</GridLayout>
3 changes: 2 additions & 1 deletion e2e/nested-router-tab-view/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/renderer/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/routable-animations/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
2 changes: 1 addition & 1 deletion e2e/router-tab-view/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { enable as traceEnable } from "tns-core-modules/trace";
// addCategories(routerTraceCategory);
traceEnable();

class MyErrorHandler implements ErrorHandler {
export class MyErrorHandler implements ErrorHandler {
handleError(error) {
console.log("### ErrorHandler Error: " + error.toString());
console.log("### ErrorHandler Stack: " + error.stack);
Expand Down
3 changes: 2 additions & 1 deletion e2e/router-tab-view/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/router/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/single-page/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
3 changes: 2 additions & 1 deletion e2e/tests-app-ng/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"paths": {
"*": [
"./node_modules/tns-core-modules/*",
"./node_modules/*"
"./node_modules/*",
"./node_modules/nativescript-angular/node_modules/*"
],
"~/*": [
"app/*"
Expand Down
1 change: 1 addition & 0 deletions nativescript-angular-package/directives/templated-items-comp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "@nativescript/angular/directives/templated-items-comp";
3 changes: 2 additions & 1 deletion nativescript-angular/directives/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ListViewComponent } from "./list-view-comp";
import { TemplateKeyDirective, SetupItemViewArgs } from "./templated-items-comp";
import { TemplateKeyDirective, SetupItemViewArgs, TemplatedItemsComponent } from "./templated-items-comp";
import { TabViewDirective, TabViewItemDirective } from "./tab-view";
import {
ActionBarComponent,
Expand Down Expand Up @@ -27,6 +27,7 @@ export {
ListViewComponent,
TemplateKeyDirective,
SetupItemViewArgs,
TemplatedItemsComponent,
TabViewDirective,
TabViewItemDirective,
ActionBarComponent,
Expand Down
2 changes: 1 addition & 1 deletion ng-sample/app/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ const customPageFactoryProvider = {
},
};

class MyErrorHandler implements ErrorHandler {
export class MyErrorHandler implements ErrorHandler {
handleError(error) {
console.log("### ErrorHandler Error: " + error.toString());
console.log("### ErrorHandler Stack: " + error.stack);
Expand Down