feat(Http): Expand support for request on local files #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Can one of the admins verify this patch? |
Contributor
|
run ci |
Contributor
Author
|
@dtopuzov the travis failure appears to be related to android build step? Shouldn't be related to these changes. Anyway you can get this all green and ready? |
Contributor
|
Hey @NathanWalker, can you rebase your PR on top of master? It should fix the travis build |
Contributor
Author
|
@sis0k0 Thank you, rebased now 👍 |
vakrilov
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands support to load local app files when using Angular's
Httpcorerequestmethod. Many apps use the basicrequestapi to construct their api calls. This allows the local file request initially implemented here to work the same for calls torequest.