[@next] tns create TestApp --ng (or --tsc) takes too long

[dtopuzov]

Steps:

npm install -g nativescript@next
tns create TestApp --tsc

Result: It takes 60+ sec.

Notes: This issue does not exist in {N} 2.4.0 official release

[tzraikov]

Fixed with https://github.com/NativeScript/template-hello-world-ts/pull/23

[dtopuzov]

Not sure template is best place to fix it, what if we have another plugin with postinstall script that do npm install?

[tzraikov]

I am not sure that it is a good practice to call npm install within a postinstall script. Is this a common practice in our scripts?

[rosen-vladimirov]

It's not common practice to have npm install in postinstall script. In fact it's a bad practice. However I'm wondering how adding a new dependency fixes this issue. Can you provide more details, @tzraikov ?

[tzraikov]

@rosen-vladimirov CLI calls npm install of the template, which now has a reference to nativescript-dev-typescript module, which has a postinstall script that calls npm install typescript. Calling npm install during npm install seems to slow down the process. The template creates a typescript project, so it seems natural to include typescript as a dependency here. As the module is already included, the second npm install does nothing and takes 0 time.

[rosen-vladimirov]

@tzraikov thanks for the explanation. I agree that our TypeScript template must have TypeScript as devDependency. However there's one thing that concerns me - in version 2.4.0 of NativeScript CLI, the issue is not reproducible, but the template there does not have TypeScript as dependency. So something in CLI's master is causing the slowness and maybe (just maybe) the current fix is hiding some other issue.
Anyway, adding TypeScript as devDependency seems absolutely correct.

[tzraikov]

@rosen-vladimirov I agree, this could be possible. AFAIK we changed the way how project templates are installed and we removed npm2 dependencies. I would suspect those changes. However, this is not necessary an issue.