Add support for custom platform templates #1525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove rimraf as dependency
Do not install the CLI
Fixes issues with Genymotion being first in the PATH
Conflicts: lib/common
Update node-winreg dependency
Merge release in master
Set version to 1.7.0
# Conflicts: # lib/common # package.json
Merge release in master
Contributor
Author
|
run ci |
1 similar comment
Contributor
Author
|
run ci |
Cleans and builds
Introduce `grunt rebuild`
lib/services/platform-service.ts
Outdated
| pathToTemplate: installedTemplatePath | ||
| }; | ||
| } catch(err) { | ||
| this.$logger.warn(`Unable to install platform template ${specifiedTemplate}. Default template will be used.`); |
Contributor
Author
There was a problem hiding this comment.
maybe we should throw correct error here instead of just printing warning
lib/services/platform-service.ts
Outdated
| let tempDir = temp.mkdirSync("platform-template"); | ||
| try { | ||
| let installedTemplatePath = this.$npm.install(specifiedTemplate, tempDir, {"ignore-scripts": true, "production": true}).wait()[0][1]; | ||
| return { |
Contributor
There was a problem hiding this comment.
If you rename installedTemplatePath, you can use the short syntax here. Not a stopper, though.
Allow build.xcconfig in app/App_Resources/iOS/build.xcconfig
# Conflicts: # lib/common
Merge release in master
Livesync does not work when /data/local/tmp/<app-identifier> file exists on Android device. This happens when a file with name app-identifier exists in /data/local/tmp directory on device. In this case CLI is not able to create directory.
…c-isit-folder Delete /data/local/tmp/<app-identifier> file if exists on Android device
Add new option when adding platform: `--platform-template`. When it is used, CLI will use the specified template instead of the default template from the runtime. The path to the specified template will be saved in project's package.json, so next time when platform is added, the same template will be used. In case when `--platform-template` is not passed, CLI will check the package.json and if there's value for the template, it will be used. Otherwise the default template from runtime will be used.
rosen-vladimirov
force-pushed
the
vladimirov/custom-native-templates
branch
from
1df7d02 to
d5bd3ad
Compare
Contributor
Author
|
Close and retarget to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option when adding platform:
--platform-template. When it is used, CLI will use the specified template instead of the default template from the runtime. The path to the specified template will be saved in project's package.json, so next time when platform is added, the same template will be used.In case when
--platform-templateis not passed, CLI will check the package.json and if there's value for the template, it will be used. Otherwise the default template from runtime will be used.Sample usage: