Add support for custom platform templates #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
original PR - #1566 |
| iOS selected runtime | `$ tns platform add ios[@<Version>] [--frameworkPath <File Path>] [--symlink] [--platformTemplate <Platform Template>]`<% } %> | ||
|
|
||
| Configures the current project to target the selected platform. <% if(isHtml) { %>When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory under the platforms directory. This platform-specific directory contains the necessary files to let you build your project for the target platform.<% } %> | ||
| Configures the current project to target the selected platform. <% if(isHtml) { %>When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory under the platforms directory. This platform-specific directory contains the necessary files to let you build your project for the target platform.<% } %> |
Contributor
There was a problem hiding this comment.
When you add a target platform, the NativeScript CLI adds a corresponding platform-specific subdirectory
->
When you add a target platform, the NativeScript CLI creates a corresponding platform-specific subdirectory
rosen-vladimirov
force-pushed
the
vladimirov/custom-native-templates
branch
from
2c52a34 to
1c0e366
Compare
| ------|------- | ||
| Android latest runtime | `$ tns platform add android [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>]` | ||
| Android selected runtime | `$ tns platform add android[@<Version>] [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>]` | ||
| Android latest runtime | `$ tns platform add android [--frameworkPath <File Path>] [--symlink] [--sdk <API Level>] [--platformTemplate <Platform Template>]` |
Contributor
There was a problem hiding this comment.
Please use the kebap-case when documenting options and switches.
Contributor
|
👍 |
Add new option when adding platform: `--platform-template`. When it is used, CLI will use the specified template instead of the default template from the runtime. The path to the specified template will be saved in project's package.json, so next time when platform is added, the same template will be used. In case when `--platform-template` is not passed, CLI will check the package.json and if there's value for the template, it will be used. Otherwise the default template from runtime will be used.
rosen-vladimirov
force-pushed
the
vladimirov/custom-native-templates
branch
from
1c0e366 to
2ce4b75
Compare
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 9, 2016
…emplates Add support for custom platform templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option when adding platform:
--platform-template. When it isused, CLI will use the specified template instead of the default template
from the runtime. The path to the specified template will be saved in
project's package.json, so next time when platform is added, the same
template will be used.
In case when
--platform-templateis not passed, CLI will check thepackage.json and if there's value for the template, it will be used.
Otherwise the default template from runtime will be used.