Fix starting of emulator when no devices are attached #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
When there are no devices attached, CLI should start emulator and execute the action on it. For example calling `tns run android` when there are no devices attached, the devicesService should start emulator and run the application in it. Currently this is not working as the startEmulator method is starting the instance and then calls method for device detection. However the checkForDevices method is async and it does not guarantee when the devices will be detected. Instead use startLookingForDevices which is synchronous.
rosen-vladimirov
force-pushed
the
vladimirov/fix-run-after-start-emulator
branch
from
dda6955 to
cda83fe
Compare
Contributor
Author
|
run ci |
1 similar comment
Contributor
Author
|
run ci |
rosen-vladimirov
added a commit
that referenced
this pull request
Mar 9, 2016
…tart-emulator Fix starting of emulator when no devices are attached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no devices attached, CLI should start emulator and execute the action on it.
For example calling
tns run androidwhen there are no devices attached, the devicesService should start emulator and run the application in it.Currently this is not working as the startEmulator method is starting the instance and then calls method for device detection.
However the checkForDevices method is async and it does not guarantee when the devices will be detected.
Instead use startLookingForDevices which is synchronous.
Fixes #1576